Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why need two terminal flags in a trajectory? #1

Open
ChenDRAG opened this issue Aug 23, 2022 · 0 comments
Open

Why need two terminal flags in a trajectory? #1

ChenDRAG opened this issue Aug 23, 2022 · 0 comments

Comments

@ChenDRAG
Copy link

ChenDRAG commented Aug 23, 2022

I have been looking into the code and notice this part of the code

VEM/main.py

Line 149 in 801af65

elif truly_dones[-1] == True:

Seems that, this "if" part add an extra "terminal" flag to the trajectory, which is very confusing, can you explain the reason why you do that?

Also could you please provide the temperature parameter beta used for the paper (default to 100 in the code) since it's missing in the ICLR paper. My reproduction of the experiment doesn't match results reported in the paper and I think this might be the reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant