-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[xterm.js 0.4.7-s] scaling problem #859
Comments
Do you mind explaining how you got to that screen? I'll try fixing the issue if I can find out how to get there.. |
Yes I see the problem. MC doesn't send stty resize commands to set the amount of rows and columns. I'm not sure how one would go about dynamically resizing the terminal without spamming the terminal with stty commands. |
I have a fix, I'll implement it when I have time (20 minutes maybe?) |
Ok I was going to implement this: But this significantly slows down running of commands. My second thought is making the agent send a signal to the terminal client. |
Wow..! How I can to test it? I need just wite for a new release of mesh? :) |
I know about this problem, I just started working with XTerm yesterday morning and released it in the afternoon, so not everything is well yet. I was going to fix this by sending a signal to the terminal (not by using stty), it will take a while to fix. |
@Ylianst that was how I was going to do it, I can do that for you if you want. How would you like me to send the data/identifier to send the signal? Just send it over the existing connection? |
Just published MeshCentral v0.4.7-t that will now set the right terminal size at the start and send the resize events to the agent. Bryan is working on getting the agent to resize the terminal now, you can search for 'termsize' in meshcore.js for the "TODO" lines. We have an agreement that when sending data on the websockets, "binary" type is data and "string" data type is control. So we can easily multiplex the terminal and control data. |
@Ylianst Well dammit I'm basically done doing this myself... |
If you have code for the 'termsize' in meshcore.js for the "TODO" lines, we would like that. Bryan and I are stumped as to how to reside the terminal once it's running. |
Step to reproduce:
THE GOOD NEWS: MC WORKS in xterm.js. YES! YES YES
The text was updated successfully, but these errors were encountered: