Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default tasks in aliases.yaml are not overwritten #14

Closed
8 tasks
johannadevos opened this issue Nov 18, 2019 · 2 comments
Closed
8 tasks

Default tasks in aliases.yaml are not overwritten #14

johannadevos opened this issue Nov 18, 2019 · 2 comments
Assignees

Comments

@johannadevos
Copy link
Contributor

johannadevos commented Nov 18, 2019

Please give us a description of what happened.

aliases.yaml in the yoast-seo-granular-control repo contains the following code:

build:
  - 'build:css'
  - 'build:js'

However, when running grunt build in that repo, the build alias from plugin-grunt-tasks/config/aliases.yaml is still carried out. This means that it is not possible to overwrite those default tasks (such as build) in other repos.

Please describe what you expected to happen and why.

When running grunt build in the yoast-seo-granular-control repo, I expected only build:css and build:js to be executed, and not also build:images and build:i18n (these latter two tasks are defined in the plugin-grunt-tasks repo.

How can we reproduce this behavior?

  1. In the terminal, navigate to the yoast-seo-granular-control repo and run grunt artifact.
  2. See that the imagemin, addtextdomain and makepot tasks are run, even though these are not specified in aliases.yaml.
  3. See that build:images and build:i18n ARE present in plugin-grunt-tasks/config/aliases.yaml.
  4. In yoast-seo-granular-control/config/aliases.yaml if you change the build tasks, you will see these changes reflected in the terminal (for example, switch around the order of build:css and build:js). This doesn't change the fact that build:images and build:i18n are ALSO executed.

Technical info

  • WordPress version:
  • Yoast SEO version:
  • If relevant, which editor is affected (or editors):
  • Classic Editor
  • Gutenberg
  • Classic Editor plugin
  • Which browser is affected (or browsers):
  • IE11
  • Edge
  • Chrome
  • Firefox
  • Safari
  • Relevant plugins in case of a bug:
  • Tested with theme:
@IreneStr
Copy link
Contributor

IreneStr commented Dec 9, 2019

Solution:

@jdevalk
Copy link

jdevalk commented Dec 9, 2019

Fixed by cb6fc3a

@jdevalk jdevalk closed this as completed Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants