Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor duplicate definitions of replacement variables #10075

Open
igorschoester opened this issue Jun 19, 2018 · 0 comments
Open

Refactor duplicate definitions of replacement variables #10075

igorschoester opened this issue Jun 19, 2018 · 0 comments

Comments

@igorschoester
Copy link
Member

igorschoester commented Jun 19, 2018

In PHP the replacement variables are determined. They are used for the meta values on a page. We pass these along to JS and use them in the snippet editor (UI for the user).
With the addition of labels (nice names) we no longer listen to PHP for the default list: values/defaultReplaceVariables.js.

I propose to change this to add support for labels inside PHP so that we can keep a single source of truth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants