You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Passing the HTML output of the Search appearance page through the W3C validator highlights a few occurrences of invalid ID attributes.
Note: I'm testing with WooCommerce activated so I get also the Woo post / taxonomies.
1
empty IDs are invalid: there are 7 occurrences of: <div class="paper tab-block" id="">
Where the ID is supposed to be the paper ID, which is null by default: <div class="paper tab-block" id="<?php echo esc_attr( $paper_id ); ?>">
Not sure why the "paper tab-block" needs an ID in the first place, however either we should always pass a paper_id or ensure the ID doesn't get printed out if paper_id is null.
2
IDs can't contain spaces:
The collapsible headings H2 have an ID that is sometimes set to a title passed via a config array or set manually as first parameter passed to WPSEO_Paper_Presenter. See for example admin/views/tabs/metas/archives.php. In one case it's an empty string (general.php). In other cases, it's set to be the post or taxonomy name (to clarify: the $object->labels->name). The passed string may contain spaces and in this case it's an invalid ID. Current occurrences:
Worth noting setting sections that are not collapsible don't use an ID on the heading. Regardless, I'm not sure what this ID is meant for in the first place.
The text was updated successfully, but these errors were encountered:
See the collapsible papers introduced in #10264.
Passing the HTML output of the Search appearance page through the W3C validator highlights a few occurrences of invalid ID attributes.
Note: I'm testing with WooCommerce activated so I get also the Woo post / taxonomies.
1
empty IDs are invalid: there are 7 occurrences of:
<div class="paper tab-block" id="">
Where the ID is supposed to be the paper ID, which is
null
by default:<div class="paper tab-block" id="<?php echo esc_attr( $paper_id ); ?>">
Not sure why the "paper tab-block" needs an ID in the first place, however either we should always pass a
paper_id
or ensure the ID doesn't get printed out ifpaper_id
is null.2
IDs can't contain spaces:
The collapsible headings H2 have an ID that is sometimes set to a title passed via a config array or set manually as first parameter passed to
WPSEO_Paper_Presenter
. See for exampleadmin/views/tabs/metas/archives.php
. In one case it's an empty string (general.php). In other cases, it's set to be the post or taxonomy name (to clarify: the$object->labels->name
). The passed string may contain spaces and in this case it's an invalid ID. Current occurrences:Worth noting setting sections that are not collapsible don't use an ID on the heading. Regardless, I'm not sure what this ID is meant for in the first place.
The text was updated successfully, but these errors were encountered: