Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include babel-polyfill in a Gutenberg 3.8 compatible way #10953

Closed
atimmer opened this issue Sep 10, 2018 · 1 comment
Closed

Include babel-polyfill in a Gutenberg 3.8 compatible way #10953

atimmer opened this issue Sep 10, 2018 · 1 comment
Milestone

Comments

@atimmer
Copy link
Contributor

atimmer commented Sep 10, 2018

After WordPress/gutenberg#9643 in Gutenberg, our babel polyfill will throw an error that there shouldn't be two babel polyfills.

We should fix this by putting our babel polyfill in a separate file/bundle completely. Then we use this as a dependency of our scripts if Gutenberg isn't around. If Gutenberg is around we can use wp-polyfill-ecmascript as a script handle.

I've put this on 8.3, as this isn't released in Gutenberg yet. And: Everything keeps on working if babel-polyfill throws this error. It is only an error in the console.

@dariaknl
Copy link
Contributor

dariaknl commented Sep 14, 2018

re-tested fix in IE11 and Edge with the following setup:

  • Gutenberg active, Gutenberg editor
  • Gutenberg deactived, default classic editor
  • Gutenberg active, Classic editor plugin ("replace Gutenberg editor" setting)
  • Gutenberg active, Classic editor plugin ("use Gutenberg editor" setting)

@dariaknl dariaknl assigned IreneStr and unassigned dariaknl Sep 14, 2018
@IreneStr IreneStr removed their assignment Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants