Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change imports of the ReplacementVariableEditor to the new package #14422

Open
2 tasks
bintzandt opened this issue Feb 25, 2020 · 1 comment
Open
2 tasks

Change imports of the ReplacementVariableEditor to the new package #14422

bintzandt opened this issue Feb 25, 2020 · 1 comment
Labels
technical-debt type: development

Comments

@bintzandt
Copy link
Contributor

bintzandt commented Feb 25, 2020 •
edited

In Yoast/javascript#505 we are creating a new package for the ReplacementVariableEditor. The Editor will also be exported from the old @yoast/search-metadata-previews package for backwards-compatibility.

This might change in the future, so it is better to change our imports now.

Additional context

See Yoast/javascript#505.

Tasks

  • Change imports of ReplacementVariableEditor from @yoast/search-metadata-previews to @yoast/replacement-variable-editor.
  • Change imports of replacementVariablesShape and recommendedReplacementVariablesShape from @yoast/search-metadata-previews to @yoast/replacement-variable-editor.
@maartenleenders maartenleenders mentioned this issue Feb 25, 2020
Closed
10 tasks
@omarreiss
Copy link
Contributor

@bintzandt is this issue still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
technical-debt type: development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@omarreiss @bintzandt @dariaknl