Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove yoast-components #19920

Closed
5 tasks done
Tracked by #19917
igorschoester opened this issue Feb 27, 2023 · 1 comment
Closed
5 tasks done
Tracked by #19917

Remove yoast-components #19920

igorschoester opened this issue Feb 27, 2023 · 1 comment

Comments

@igorschoester
Copy link
Member

igorschoester commented Feb 27, 2023

In general this package was our first components package. It got replaced by @yoast/components, which in turn is being phased out by @yoast/ui-library.
This packages acts as wrapper around other packages, like metadata-previews, analysis-report, replace-var-editor. But Free actually depends on the packages themselves directly.

There are 3 phases:

  1. (Re)moving the usages of yoast-components
  2. Removing yoast-components sourcecode
  3. Deprecating yoast-components (on NPM)

Each phase should be separated by some time. Let's say one release each of the affected plugins.

Tasks

  1. vraja-pro
  2. thijsoo
@marijnyoast
Copy link
Contributor

[refinement 15-03-23]

We wanne be careful around deprecations since other people might be using our packages. Also consult @d-claassen to have a conversation around the impact for Shopify.

@igorschoester Will have a meeting with other devs to split this out in phases. Probably a sort of pairing session. Might be good to even talk about this in the state of the code.

The idea is to first copy packages, then remove them.

Keep track of how we attack that and document it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants