Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippet updates #6042

Closed
jdevalk opened this issue Nov 8, 2016 · 3 comments
Closed

Snippet updates #6042

jdevalk opened this issue Nov 8, 2016 · 3 comments

Comments

@jdevalk
Copy link
Contributor

jdevalk commented Nov 8, 2016

What did you expect to happen?

For the snippet preview to match the Google snippet in style.

What happened instead?

Not that.

Preview:
edit_post_ yoast _wordpress

Actual:
yoast_seo_3_8_-_google_search

Differences:

  1. Bold in the description didn't show in preview, with focus keyword Yoast SEO 3.8 set.
  2. Downward pointing triangle is missing in preview.
  3. Grayish text for meta description in actual result (this might be a Google test, verify that it's still the case).
  4. No support for breadcrumbs (if they're on in our plugin).
  5. Date doesn't show for "recent" posts, would be cool if we behaved the same way.

1 and 2 should certainly be fixed, 3 should be checked, 4 is probably a separate issue as it's probably slightly more work, but should also be fixed. 5 is fun, mostly, no must.

How can we reproduce this behavior?

Check any post.

Technical info

  • WordPress version: 4.6
  • Yoast SEO version: 3.8
@jdevalk jdevalk added this to the 3.9 milestone Nov 8, 2016
@afercia
Copy link
Contributor

afercia commented Nov 9, 2016

Not sure it's a priority, I guess it's a minor point, but since I'm currently working on colors I've noticed very subtle differences in the colors used on the preview and by G, probably they recently adjusted the colors shades. For completeness, the differences are:

blue title
snippet #1e0fbe
google  #1a0dab

grey meta text
snippet #333
google  #545454

grey meta text bold
snippet #333
google  #6a6a6a

About the grey shades, if a perfect match is not a priority, I'd consider to don't add two more colors just for the snippet. We already have a lot of shades of grey :)

@jdevalk
Copy link
Contributor Author

jdevalk commented Nov 9, 2016

I think the CSS for the snippet should be wholly separate from everything else and we should try to match as completely as possible.

@terw-dan
Copy link
Member

I've created 2 new issues for the 4th and 5th enhancement in this issue. #6134 and #6135
The other enhancements are already merged, so this issue can be closed.

@terw-dan terw-dan removed the queue label Nov 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants