Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications for helper plugins do not get dismissed #9287

Open
hedgefield opened this issue Mar 20, 2018 · 2 comments
Open

Notifications for helper plugins do not get dismissed #9287

hedgefield opened this issue Mar 20, 2018 · 2 comments

Comments

@hedgefield
Copy link
Contributor

Please give us a description of what happened.

Every now and then I stumble on a notification that does not correctly get dismissed when the situation resolves. In this case, it's the 'upsells' for the Yoast ACF and WooCommerce SEO plugins.

screencapture-wordpress-develop-local-wp-admin-admin-php-2018-03-20-15_31_46

Please describe what you expected to happen and why.

I expect that when I disable and/or delete the WooCommerce or ACF (PRO) plugins, the Yoast notifications saying 'those would work better with Yoast ACF and WooCommerce SEO' are removed. Instead, they persist and aside from dismissing them there doesn't seem to be a way to force them to resolve (unless maybe reinstalling the plugins and activating them all).

How can we reproduce this behavior?

  1. Install and activate ACF / WooCommerce.
  2. Install and activate Yoast SEO.
  3. Get the notifications.
  4. Deactivate and delete ACF / WooCommerce.
  5. The notifications in Yoast SEO do not go away.

Also, through some sequence of events that I cannot reproduce but may be worth nothing is that both ACF PRO and Yoast ACF are now active on my local WP while the notification that says I should install Yoast ACF is still visible.

Technical info

  • WordPress version: 4.9.4
  • Yoast SEO version: 7.1
  • Yoast ACF version: 2.0.1
  • ACF (PRO) version: 4.4.12 and 5.6.9 (early access)
  • Relevant plugins in case of a bug: Gutenberg & Health Check
  • Tested with theme: Twentyseventeen
@hedgefield hedgefield added the bug label Mar 20, 2018
@hedgefield hedgefield changed the title Notifications for Yoast ACF and Woocommerce SEO do not get dismissed Notifications for helper plugins do not get dismissed Mar 20, 2018
@Djennez
Copy link
Member

Djennez commented Jun 26, 2019

Yep, this is still the case currently (11.6-RC1)

@jeroenrotty
Copy link
Contributor

Still reproducible with 20.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants