Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit hardcoded colors and replace them with variables #748

Open
afercia opened this issue Oct 1, 2018 · 0 comments
Open

Audit hardcoded colors and replace them with variables #748

afercia opened this issue Oct 1, 2018 · 0 comments

Comments

@afercia
Copy link
Contributor

afercia commented Oct 1, 2018

Noticed while looking at #703

The only way to to keep the colors palette under control in the long term, is to use only and exclusively colors variables from the palette. That's the reason why a style guide with a defined colors palette has been created.

However, over time, some colors have been hardcoded in the codebase, for example

background-color: #fff;
color: #32373c;

where the white is a minor issue but #32373c isn't part of the Yoast palette and shouldn't be used. When there's the need for a new color, please discuss with the design team and carefully evaluate how often it will be actually used: if it's going to be used just once or twice, it's probably not really needed.

One more case of color that we've hardcoded is the #5b9dd9 blue from WordPress. as we're using it more and more, especially for the focus style, I'd propose to add it to the color palette. Alternatively, explore a way to have a sort of "JS style mixin" for the focus style that can be reused across the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant