Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: make codebase null-safe compatible #20

Merged
merged 31 commits into from
Nov 19, 2021
Merged

Conversation

ses110
Copy link
Contributor

@ses110 ses110 commented Nov 15, 2021

Refactors to make codebase null-safe compatible

ses110 and others added 25 commits November 15, 2021 15:11
@ses110 ses110 marked this pull request as ready for review November 19, 2021 16:10
@ses110 ses110 requested a review from a team as a code owner November 19, 2021 16:10
@ses110 ses110 requested review from grizzly-atoms and rlperez and removed request for a team November 19, 2021 16:10
@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #20 (68334a5) into main (1cd7e7d) will increase coverage by 0.33%.
The diff coverage is 97.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   93.95%   94.28%   +0.33%     
==========================================
  Files           9        9              
  Lines         281      280       -1     
==========================================
  Hits          264      264              
+ Misses         17       16       -1     
Impacted Files Coverage Δ
lib/ui/ring_border.dart 80.00% <ø> (ø)
lib/providers/lock_provider.dart 95.83% <87.50%> (ø)
lib/assets/traits/device_item_icon.dart 100.00% <100.00%> (ø)
lib/components/arc.dart 90.81% <100.00%> (ø)
lib/components/device_control.dart 95.65% <100.00%> (ø)
lib/components/lock_widget.dart 92.85% <100.00%> (ø)
lib/components/modes_toolbar.dart 100.00% <100.00%> (+1.81%) ⬆️
lib/providers/thermostat_provider.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cd7e7d...68334a5. Read the comment docs.

@ses110 ses110 changed the title refactor: fix imports to use classes and methods directly exported by… BREAKING CHANGE: make codebase null-safe compatible Nov 19, 2021
@ses110 ses110 merged commit 9261801 into main Nov 19, 2021
stewartjarod pushed a commit that referenced this pull request Nov 19, 2021
# [2.0.0](v1.1.0...v2.0.0) (2021-11-19)

### Bug Fixes

* all tests passing ([6999c74](6999c74))
* build test code ([e247044](e247044))
* Fix build from any Null test error ([15edc76](15edc76))
* Fix lock_provider_test mock method signatures and tests ([8a4b30b](8a4b30b))
* Fix lock_provider_test mock method signatures and tests ([897a7bb](897a7bb))
* Fix mock lock provider get details function signature ([37a9b72](37a9b72))
* flutter version ([199efaa](199efaa))
* injection method non nullable ([ba7aeff](ba7aeff))
* merge fixes ([ce6b92f](ce6b92f))
* mocking lockunlocak ([a691110](a691110))
* modes_toolbar_test ([554b316](554b316))
* provider tests ([0f619f4](0f619f4))
* Remove bad implicit casts ([483a529](483a529))
* updated sdk dependency ([beed178](beed178))

* Merge pull request #20 from Yonomi/fix_dependencies ([9261801](9261801)), closes [#20](#20)

### BREAKING CHANGES

* make codebase null-safe compatible
@ses110 ses110 deleted the fix_dependencies branch December 8, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants