Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DX-353): display IsJammed State if device supports it #37

Merged
merged 41 commits into from
Feb 17, 2022
Merged

feat(DX-353): display IsJammed State if device supports it #37

merged 41 commits into from
Feb 17, 2022

Conversation

ses110
Copy link
Contributor

@ses110 ses110 commented Feb 15, 2022 •
edited
Loading

Screenshots

image

image

@ses110 ses110 requested a review from a team as a code owner February 15, 2022 15:48
@ses110 ses110 requested review from surajadh and rlperez and removed request for a team February 15, 2022 15:48
@codecov
Copy link

codecov bot commented Feb 15, 2022 •
edited
Loading

Codecov Report

Merging #37 (f4f7f2d) into main (90cd4dd) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   98.23%   98.41%   +0.17%     
==========================================
  Files          34       35       +1     
  Lines         909      948      +39     
==========================================
+ Hits          893      933      +40     
+ Misses         16       15       -1
Impacted Files Coverage Δ
lib/providers/device_provider.dart 100.00% <ø> (ø)
lib/ui/widget_style_constants.dart 100.00% <ø> (ø)
lib/components/device_control.dart 100.00% <100.00%> (+4.34%) ⬆️
lib/providers/lock_provider.dart 100.00% <100.00%> (ø)
lib/providers/thermostat_provider.dart 100.00% <100.00%> (ø)
lib/traits/lock_widget.dart 100.00% <100.00%> (ø)
lib/traits/slim/lock_slim_widget.dart 100.00% <100.00%> (ø)
lib/traits/slim/thermostat_slim_widget.dart 100.00% <100.00%> (ø)
lib/traits/thermostat_widget.dart 100.00% <100.00%> (ø)
lib/ui/notification_bar.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90cd4dd...f4f7f2d. Read the comment docs.

@ses110
Copy link
Contributor Author

ses110 commented Feb 15, 2022

For some reason CodeCov doesn't pick up usage of getters in Dart:
image

when it's clearly being used in lock_widget.dart:
image

@rlperez
Copy link
Member

rlperez commented Feb 15, 2022

I added a commit that should address the code coverage. I think?

@rlperez
Copy link
Member

rlperez commented Feb 15, 2022

I noticed the sdk side of this while looking around that both IsJammed and IsLocked states share the same state name. Will this potentially be an issue in the future?

@ses110
Copy link
Contributor Author

ses110 commented Feb 15, 2022

I noticed the sdk side of this while looking around that both IsJammed and IsLocked states share the same state name. Will this potentially be an issue in the future?

Good catch, I'll push a quick PR to fix that in the SDK

@ses110
Copy link
Contributor Author

ses110 commented Feb 16, 2022

image

ses110 and others added 23 commits February 15, 2022 19:22
@ses110
fix(lock_widget): follow Figma style guide
281b2bc
@ses110
test(lock_widget): update tests
1f08ca4
@yonomi-developer
docs: updated dartdocs
f80f13b
@ses110
refactor(lock_widget): remove unused method
3beb485
@yonomi-developer
docs: updated dartdocs
c4e08bd
@yonomi-developer
docs: updated dartdocs
f8b4a24
@yonomi-developer
docs: updated dartdocs
d2ca91e
@ses110
refactor(lock_widget): extract notification to new widget
97e3b7a
@yonomi-developer
docs: updated dartdocs
31bf190
@yonomi-developer
docs: updated dartdocs
39bbd10
@yonomi-developer
docs: updated dartdocs
a5a8a18
@yonomi-developer
docs: updated dartdocs
38e0032
@yonomi-developer
docs: updated dartdocs
880e8f5
@yonomi-developer
docs: updated dartdocs
1f6c7a4
@yonomi-developer
docs: updated dartdocs
b918a98
@yonomi-developer
docs: updated dartdocs
a3acc80
@yonomi-developer
docs: updated dartdocs
673f589
@ses110
test(lock_widget_test): add more tests
32f4515
@yonomi-developer
docs: updated dartdocs
4f8ecce
@yonomi-developer
docs: updated dartdocs
ae173c0
@ses110
fix(lock_widget_test): fix onTap behavior test
61ea00d
@yonomi-developer
docs: updated dartdocs
18d3586
@yonomi-developer
docs: updated dartdocs
f4f7f2d
@ses110 ses110 merged commit e82f8d4 into main Feb 17, 2022
@ses110 ses110 deleted the DX-353/lock_isJammed branch February 17, 2022 17:14
stewartjarod pushed a commit that referenced this pull request Feb 17, 2022
@semantic-release-bot
chore(release): 2.7.0 [skip ci]
3f8939a 
# [2.7.0](v2.6.0...v2.7.0) (2022-02-17)

### Features

* **DX-353:** display IsJammed State if device supports it ([#37](#37)) ([e82f8d4](e82f8d4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlperez rlperez rlperez approved these changes

@surajadh surajadh Awaiting requested review from surajadh surajadh is a code owner automatically assigned from Yonomi/dx

@grizzly-atoms grizzly-atoms Awaiting requested review from grizzly-atoms

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ses110 @rlperez @yonomi-developer