Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ColorTemperature): ColorTemperature dynamic widget (DX-362) #44

Merged
merged 19 commits into from
Apr 26, 2022

Conversation

ses110
Copy link
Contributor

@ses110 ses110 commented Apr 19, 2022

Pre-requisites before merging this PR:

  • In yonomi-sdk-dart repository, DX-362/set_color_action branch is merged into main (PR link is here)
  • Update pubspec.yaml to remove yonomi-sdk-dart git reference and instead use version uploaded to pub.dev

@ses110 ses110 changed the title ci: generate dartdocs and push new PR after merging to main feat(ColorTemperature): ColorTemperature dynamic widget (DX-362) Apr 19, 2022
@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #44 (97ac9ea) into main (0dfebf3) will increase coverage by 0.07%.
The diff coverage is 99.32%.

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   98.61%   98.68%   +0.07%     
==========================================
  Files          41       45       +4     
  Lines        1226     1369     +143     
==========================================
+ Hits         1209     1351     +142     
- Misses         17       18       +1     
Impacted Files Coverage Δ
lib/providers/device_provider.dart 100.00% <ø> (ø)
lib/traits/detail_screen.dart 78.94% <75.00%> (-1.61%) ⬇️
lib/assets/traits/color_temperature_icon.dart 100.00% <100.00%> (ø)
lib/assets/traits/device_item_icon.dart 100.00% <100.00%> (ø)
lib/providers/color_temperature_provider.dart 100.00% <100.00%> (ø)
lib/providers/thermostat_provider.dart 100.00% <100.00%> (ø)
lib/traits/color_temperature_widget.dart 100.00% <100.00%> (ø)
lib/traits/device_widget_factory.dart 100.00% <100.00%> (ø)
lib/traits/slim/color_temperature_slim_widget.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dfebf3...97ac9ea. Read the comment docs.

@ses110 ses110 marked this pull request as ready for review April 22, 2022 17:30
@ses110 ses110 requested a review from a team as a code owner April 22, 2022 17:30
@ses110 ses110 requested review from grizzly-atoms, surajadh, rlperez and a team and removed request for a team and surajadh April 22, 2022 17:30
@rlperez rlperez merged commit ae07596 into main Apr 26, 2022
@rlperez rlperez deleted the DX-362/colortemperature branch April 26, 2022 01:36
yonomi-developer pushed a commit that referenced this pull request Apr 26, 2022
# [2.10.0](v2.9.0...v2.10.0) (2022-04-26)

### Features

* **ColorTemperature:** ColorTemperature dynamic widget (DX-362) ([#44](#44)) ([ae07596](ae07596))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants