Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pin_code_widget): Detail view, Edit or Delete PIN Code(s) #55

Merged
merged 50 commits into from
Sep 28, 2022
Merged

feat(pin_code_widget): Detail view, Edit or Delete PIN Code(s) #55

merged 50 commits into from
Sep 28, 2022

Conversation

ses110
Copy link
Contributor

@ses110 ses110 commented Sep 19, 2022 •
edited
Loading

PIN Code Detail screen:

PIN Code Detail

PIN Code List screen:

Pin Code List

@ses110
feat(pin_code_icon): introduce pin_code_icon
f5bf257
@ses110
feat(pin_code_provider): introduce PinCodeProvider
4d5c83f
@ses110
build(pubspec.yml): temporarily point to dart sdk git branch
ade3f19
@ses110
chore(pin_code_provider): fix dartdoc comments
a98ef67
@ses110
refactor(brightness_slim_widget): quick refactor
3dfb08d
@ses110
feat(pin_code): introduce pin code slim widget
ba1d3d9
@ses110
fix: small fixes
241e5ab
@ses110
feat(pin_code_widget): new pin code widget
5d7b3e6
@ses110
feat(pin_code): add pin code entry to factories
30725b2
@ses110
feat(pin_code_widget): include pin_code_slim_widget in factory
90df88b
@ses110
refactor(pin_code_slim_widget): update icons
805bd15
@ses110
feat(pin_code_widget): carve out pin code widget details
ad807c1
@ses110
chore: small changes
0aae784
@ses110
feat(pin_code_slim_widget): show bottom sheet on click
ced130c
@ses110
fix(pin_code_widget): fix icon size and color
d986664
@ses110
feat(pin_code_slim_widget): add basic list and detail view navigation
8590295
@ses110
build(pubspec.yml): remove ref to specific branch
b331433
@ses110
feat(pin_code_slim_widget): Detail View implementation to create new …
67221db 
…pin code
@ses110
fix(pin_code_detail_view): add async modifier to onPressed callback
84f93b9
@ses110
refactor(pin_code_slim_widget): minor fixes
43b2e2d
@ses110
test(detail_screen_test.dart): add pinCodeProvider mocks to existing …
5e720da 
…tests
@ses110
refactor(pin_code_slim_widget): add sub-navigation between sheets
5247087
@ses110
feat(pin_code_widget): save new pin code
32dae14
@ses110
feat(pin_code): update widget according to figma designs
cfcf4d6
@ses110
feat(pin_code): update styles according to figma design
25efbdc
@ses110
refactor(pin_code_provider): rename from sendAddPinCode to sendCreate…
404815d 
…PinCode method name
@ses110
test(pin_code_provider): more tests for pin_code_provider
832ce60
@ses110
refactor(pin_code_provider): rename action to sendCreatePinCode
d6e9b0c
@ses110
test(pin_code_slim_widget): add tests to cover List View and Detail V…
e8b33ab 
…iew screens
@ses110
chore(pin_code_provider): fix comment
fd619e7
@ses110
test(detail_screen): add tests for PinCodeWidget
f99427c
@ses110
feat(pin_code_widget): tap on existing pin code to view details
9e14fe2
@ses110
feat(pin_code_provider): methods to update or delete a pin code
224ad9c
@ses110
refactor(pin_code_detail): style Delete Button
7448313
@ses110
refactor(pin_code_detail): obscure PIN Code field
9d6136f
@ses110
refactor(pin_code_widget): refactor text input validation
cf128c7
@ses110
refactor(pin_code_slim_widget): call updatePinCode Mutation if editin…
39c7f46 
…g existing PIN Code
@ses110
feat(pin_code_detail): on delete button press, show dialog to confirm
42bea4f
@ses110
test(pin_code_widget): tests around deleting a PIN Code
e4174be
@ses110
test(pin_code_widget): one more test for deleting a PIN Code
ca4a0bf
@ses110
test(pin_code_widget): fix code and test to dismiss dialog after dele…
2de292d 
…ting PIN Code
@ses110
feat(pin_code_detail): no saving allowed if no changes were made
28e83eb
@ses110
refactor(pin_code_list): fix styles for list view items
286e609
@ses110
refactor(pin_code_detail): eye icon to display or obscure pin code
01620ea
@ses110 ses110 changed the title feat(pin_code_widget): Detail view for existing Pincodes feat(pin_code_widget): Detail view, Edit or Delete PIN Code(s) Sep 22, 2022
@ses110 ses110 marked this pull request as ready for review September 27, 2022 20:36
@ses110 ses110 requested a review from a team as a code owner September 27, 2022 20:36
@ses110 ses110 requested review from grizzly-atoms, rlperez and JohnCrafton and removed request for a team September 27, 2022 20:36
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 99.21% // Head: 99.37% // Increases project coverage by +0.16% 🎉

Coverage data is based on head (8b3602c) compared to base (9eaf083).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   99.21%   99.37%   +0.16%     
==========================================
  Files          48       48              
  Lines        1528     1604      +76     
==========================================
+ Hits         1516     1594      +78     
+ Misses         12       10       -2
Impacted Files Coverage Δ
lib/providers/pin_code_provider.dart 100.00% <100.00%> (ø)
lib/traits/slim/pin_code_slim_widget.dart 100.00% <100.00%> (+1.73%) ⬆️
lib/ui/widget_style_constants.dart 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ses110 ses110 merged commit 1c50e6a into main Sep 28, 2022
@ses110 ses110 deleted the detail_view_pincode branch September 28, 2022 14:54
yonomi-developer pushed a commit that referenced this pull request Sep 28, 2022
@semantic-release-bot
chore(release): 2.12.0 [skip ci]
5b3f2f8 
# [2.12.0](v2.11.0...v2.12.0) (2022-09-28)

### Features

* **pin_code_widget:** Detail view, Edit or Delete PIN Code(s) ([#55](#55)) ([1c50e6a](1c50e6a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnCrafton JohnCrafton JohnCrafton approved these changes

@grizzly-atoms grizzly-atoms Awaiting requested review from grizzly-atoms grizzly-atoms is a code owner automatically assigned from Yonomi/dx

@rlperez rlperez Awaiting requested review from rlperez rlperez is a code owner automatically assigned from Yonomi/dx

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ses110 @JohnCrafton