Add create and remove book using redux #2
Conversation
There was a problem hiding this comment.
Hi @Yothu,
Good job so far!
Highlight!
- Good feature branch name ✔️
- No linter errors ✔️
- Descriptive pull request ✔️
- Descriptive commit messages ✔️
- Good code organization and working app ✔️
- Descriptive README ✔️
Hello ✋, you have done well reaching this point of the milestone 🤝 . But there are some issues that you still need to work on to go to the next project but you are almost there!
Status: Required Changes ♻️⛔️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread and tag me @julie-ify if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
src/components/BookForm.js
Outdated
| const newBook = { | ||
| id, | ||
| title, | ||
| author: 'Robert', | ||
| }; | ||
| dispatch(addBook(newBook)); | ||
| setTitle(''); | ||
| }; | ||
|
|
||
| return ( | ||
| <FormContainer> | ||
| <AddBook>ADD NEW BOOK</AddBook> | ||
| <form> | ||
| <input type="text" name="name" placeholder="Book title" /> | ||
| <select> | ||
| <option disabled selected>Category</option> | ||
| <form onSubmit={submitBookToStore}> | ||
| <input type="text" onChange={(e) => setTitle(e.target.value)} value={title} placeholder="Book title" /> | ||
| <select defaultValue="DEFAULT"> | ||
| <option value="DEFAULT" disabled>Category</option> | ||
| </select> |
There was a problem hiding this comment.
- Good job so far 👍. However, instead of having a default author
author: 'Robert'each time a book is created, and a defaultcategoryoption, why don't you add several categories in which users can select any category they like out of the ones you provided or you can remove this categoryselecttag and use normalinputtag for the author just like the input for the title where you allow users to addauthorof the book they added 🤔. Think about this and choose one option and implement it instead of having it as default. 👍
There was a problem hiding this comment.
Hi @Yothu,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Description
This pull request is about configuring the Redux Store and creating actions and reducer for adding and removing books.
Project Requirements
configureStore.jsfile.References
For a more detailed description of the project's instructions check this page.
Usage
To know how to install and use this project check the README.md file!.