Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth: User Register #34

Merged
merged 20 commits into from Jun 9, 2022
Merged

Auth: User Register #34

merged 20 commits into from Jun 9, 2022

Conversation

Bondok6
Copy link
Collaborator

@Bondok6 Bondok6 commented Jun 8, 2022

Hey @eduardosancho, @Yothu

I tried to explain what I did using some comments.

This is the final result, when the user fills the signup form, you should get these steps:

  1. the initial state @init
  2. auth/register/pending -> we can apply loading spinner or anything later.
  3. auth/register/rejected -> of course, we will get rejected at this point because there is no real API yet.
  4. auth/register/reset -> to reset the state.

2

You can use the same approach to implement the login and logout inside the same files.

@Yothu Yothu added the enhancement New feature or request label Jun 9, 2022
@eduardosancho eduardosancho self-requested a review June 9, 2022 20:19
Copy link
Collaborator

@eduardosancho eduardosancho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Yothu & @Bondok6 & @eduardosancho ,

Your branch is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Yothu Yothu merged commit f6757e6 into development Jun 9, 2022
@Yothu Yothu deleted the feature/auth branch June 9, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants