Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/hotel details #35

Merged
merged 16 commits into from Jun 8, 2022
Merged

Feature/hotel details #35

merged 16 commits into from Jun 8, 2022

Conversation

eduardosancho
Copy link
Collaborator

@eduardosancho eduardosancho commented Jun 8, 2022 •
edited

What was done in this PR by @eduardosancho 馃巸 :

  • Add a mockup/temporary page for hotels index.
  • Add a hotel details page and populate it with information from a JSON.
  • Style the page, considering responsiveness.

Closes issue #7.

Button actions were moved to issue #36, for addition later.

@eduardosancho eduardosancho self-assigned this Jun 8, 2022
@eduardosancho eduardosancho linked an issue Jun 8, 2022 that may be closed by this pull request
[6pts] Hotel Details #7
Closed
4 tasks
@eduardosancho eduardosancho added the enhancement New feature or request label Jun 8, 2022
Bondok6
Bondok6 approved these changes Jun 8, 2022
View reviewed changes
Copy link
Collaborator

@Bondok6 Bondok6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eduardosancho ,

Great work! Let's merge it. 馃帀

Gif found on CodeReviewGifs.com hosted on Giphy.com

Cheers and Happy coding!馃憦馃憦馃憦

@eduardosancho eduardosancho merged commit 5f93364 into development Jun 8, 2022
@eduardosancho eduardosancho deleted the feature/hotel-details branch June 8, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bondok6 Bondok6 Bondok6 approved these changes

Assignees

@eduardosancho eduardosancho

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[6pts] Hotel Details
2 participants
@eduardosancho @Bondok6