Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup and dependencies #26

Merged
merged 3 commits into from Mar 1, 2022
Merged

Setup and dependencies #26

merged 3 commits into from Mar 1, 2022

Conversation

Yothu
Copy link
Owner

@Yothu Yothu commented Mar 1, 2022

Description

Initial setup and dependencies configuration for the React & Redux group project - Space Travelers' Hub.

Issue of this pull request:

@Yothu Yothu added the Setup Initial configuration label Mar 1, 2022
@Yothu Yothu requested a review from OmarRamoun March 1, 2022 16:30
@Yothu Yothu self-assigned this Mar 1, 2022
Copy link

@OmarRamoun OmarRamoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: INVALID 🟡

Hi @Yothu ,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request 😢

You have submitted a project, that the linters checks in GitHub are failing, kindly make sure the linters are passing before sending it for review.

programming-punching-keyboard-coding-anger-13716030304

CHEERS AND HAPPY CODING!! 👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

@Yothu Yothu requested a review from OmarRamoun March 1, 2022 16:48
Copy link

@OmarRamoun OmarRamoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @Yothu

You have done such a great job.

Now, you can merge it 👍

Comment on lines +1 to +4
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I think it would be awesome if you do not commit the public folder. Only commit production code.

@Yothu Yothu merged commit c77d65e into develop Mar 1, 2022
@Yothu Yothu deleted the feature/setup-and-dependencies branch March 1, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Setup Initial configuration
Projects
No open projects
React Group Project
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants