Change relative path to ydbmerrors to use src directory #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the YDB_SOURCE_DIR cmake variable to get the path to ydbmerrors.h instead of a hardcoded relative path
nars1
approved these changes
Feb 19, 2018
|
And he's off!
…On Mon, Feb 19, 2018 at 10:41 AM, Narayanan Iyer ***@***.***> wrote:
Merged #161 <#161>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#161 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABEtwj_Qvsz62OqJxiP43yHs1QVbRf4oks5tWZYsgaJpZM4SKvUW>
.
|
nars1
pushed a commit
to YottaDB/YDBDoc
that referenced
this pull request
Jun 9, 2021
Continuous deployments work correctly as long as the pipeline passes. Unfortunately, the pipeline is not currently passing, and fixing it is not trivial. Here are the current errors, taken from https://gitlab.com/jyn514/YDBDoc/-/jobs/791375698 and https://gitlab.com/jyn514/YDBDoc/-/jobs/793823039: ``` Found invalid urls in /builds/jyn514/YDBDoc/target/AcculturationGuide/acculturation.html: Error fetching http://worldvista.org/AboutVistA: http://worldvista.org/AboutVistA: timed out Unexpected HTTP status fetching YottaDB/YDB#109: 429 Too Many Requests Unexpected HTTP status fetching YottaDB/YDB#161: 429 Too Many Requests Unexpected HTTP status fetching YottaDB/YDB#186: 429 Too Many Requests Unexpected HTTP status fetching YottaDB/YDB#188: 429 Too Many Requests Unexpected HTTP status fetching YottaDB/YDB#145: 429 Too Many Requests ``` Note that all these URLs exist, the only problem is that the pipeline is rate-limited or the request times out. There are a few possible solutions: - Don't check HTTP pages at all. This will catch fewer failures, but not have any spurious failures at all. - Retry pages that fail. This will require upstream support in cargo-deadlinks (deadlinks/cargo-deadlinks#53). It will not help with rate-limits (since the retries will also count against the limit). - Ignore failures in some websites. This requires upstream support (deadlinks/cargo-deadlinks#57). It will help with both issues. - Add a GitHub token in the environment to increase the rate limit. This will not fix the issues with timeouts, but should fix the vast majority of other errors. Unfortunately, it also requires storing secrets in pipelines and having a dedicated GitHub account for this. GitLab has support for storing secret credentials, so this is feasible. - Change some of the URLs to point to GitLab. This will help with the GitHub rate limits but not with the VistA timeout. - Remove some URLs from the documentation. This is not a _good_ solution, but it is _a_ solution. The change implemented here is to not check HTTP pages at all. If in the future deadlinks has more support for retries, the check could be re-enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final Release Note
The YDB_SOURCE_DIR cmake variable is used to get the path to
ydbmerrors.hinstead of a hardcoded relative path. (#161)