Implemented wallet class for buying, selling, creating and retrieving… #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improved the exceptions check for methods. - Fixed typos in some methods. - Updated response object to direct values.
Invalid auth keys can be passed or any client error can occur. First step is to catch HTTPErrors :+!:
Check for errors against a response and exception. If there's an error, raise the appropriate exception.
… wallet address and also checking network fee
Closed
Youngestdev
reviewed
Jan 31, 2021
There was a problem hiding this comment.
- Method names should be in camelCase.
- queries should be executed in a
try...exceptblock.ClientErrorexception should also be included in the except block. - Uniformity: should be
self._execute_request(self.query=self.__query, variables=__variables)Not
self._execute_request(self.__query, variables=__variables)Or
self._execute_request(self.query=self.__query, __variables)
Youngestdev
approved these changes
Jan 31, 2021
buycoins/wallets.py
Outdated
| try: | ||
| response = self._execute_request(query=self.__query, variables=__variables) | ||
| check_response(WalletError, response) | ||
| except WalletError as e: |
There was a problem hiding this comment.
This should be except (WalletError, ClientError) as e:.
Effect the changes for the other try...except block.
buycoins/wallets.py
Outdated
| try: | ||
| response = self._execute_request(query=self.__query, variables=__variables) | ||
| check_response(WalletError, response) | ||
| except WalletError as e: |
There was a problem hiding this comment.
This should be except (WalletError, ClientError) as e:.
Effect the changes for the other try...except block.
buycoins/wallets.py
Outdated
Comment on lines
223
to
224
| if len(address) == 34: | ||
| raise WalletError("Invalid address") |
Repository owner
locked and limited conversation to collaborators
Feb 1, 2021
Repository owner
unlocked this conversation
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… wallet address and also checking network fee
Wallet Class:
Creating a receiving address for a cryptocurrency
Allowing the purchase of a cryptocurrency
Allowing the sale of a cryptocurrency.
Calculating the network fee for a currency's amount