Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few questions and comments #1

Open
SaundersMark opened this issue Jul 25, 2023 · 0 comments
Open

A few questions and comments #1

SaundersMark opened this issue Jul 25, 2023 · 0 comments

Comments

@SaundersMark
Copy link

Hello,

I hope you don't mind me adding some comments and questions. I've had a look at your paper and the dataset:

  1. I am not clear on how you do the SDR calculations in the contexts of the segmentation models. 5.2.1 gives the fomula:

SDR=10log10 ||m||2
||˜m−m||2

It looks to me that m is the mask and ˜m is the predicted mask. Is that right?

  1. Another way would be to calculate SDR based on the audio wave rather than in the frequency domain. However, the lengths of the original and denoised audio waves in the dataset are not always the same and so do this it would seem to be necessary to spend time correlating the signals. The report doesn't mentioned that you did that (but I may have missed it). So presumably, the SDR for the mask-based segmentation models was done for the masks rather than the reconstructed audio?

  2. I think that there may be a typo in the formula for IoU in section 5.2.1. Should the denominator be A∪B ?

  3. I noticed that some of the masks in the dataset appear to be empty (e.g. XC175650_left,XC462632_left, XC462680_left, XC463223_left, XC463661, XC469469_left, XC49097, XC490972_left, XC496206_left).

Thanks you

Mark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant