fix: correct fields tab traverse #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoussefRaafatNasry
changed the title
YoussefRaafatNasry
force-pushed
the
fix-tab-traversal-support
branch
from
7cfa60c
to
d215d8d
Compare
|
Thanks @Leviatanus for fixing this! |
|
Glad that I could have helped! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection with issue(s)
Resolve issue #5
Testing and Review Notes
Hello, while developing multi-platform Flutter app with the awesome LoForm I have encountered a problem with UX (especially on desktop). Changing between fields with tab key did not work, because in lo_field.dart Focus was the child of FocusScope which 'traps' the tab traversal to the FocusNodes under given FocusScope. The solution was to remove FocusScope widget and add skipTraversal = true to the Focus widget (TextField already has FocusNode attached, therefore the Focus that we add does not need to be available to be focused (otherwise one tab click removes the Focus from the field and only then the next tab click moves the focus to the next FocusNode.))
To test this functionality example project can be compiled on any platform and then tab key can be used to change between fields.
All current unit tests still do pass.
To Do