-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go-libusb is deprecated and archived #3
Comments
The conversion looks pretty straightforward to me. There are a few renames and there's no simple function like Unfortunately, I don't any of this hardware, so I don't want to open a PR for something I can't test. |
Please also note that the repository owner does not think anyone should use it (though now I'm thinking one of the contributors here probably opened that PR.) |
We are aware of this and we are happy for any patches if you cannot wait for us to migrate. |
@QuLogic |
@trebortech feel free to try this branch: https://github.com/QuLogic/yubihsm-connector/tree/gousb |
@QuLogic I had some time to test your fork and I found two cases where it doesn't work correctly:
Regarding point 1, gousb doesn't even set If these two points are resolved I would be happy to merge this. |
OK, I guess that's what's done here, but I don't see |
Yes, that's where the ZLP is sent. Let me elaborate on |
Maybe try removing this condition and see if it works? |
Yes, that's the condition that doesn't let the ZLP through; without it the plain echo works. |
The go-libusb library [1] used in yubihsm-connector is deprecated (and archived fork of [2]).
From packaging and security point of view, it is not a good idea to package archived fork of deprecated library.
Would it be possible to use the original version or "migrate" to the new gousb [3] that is alive and kicking?
I am not a go developer so I do not know what would it take to do so.
[1] https://github.com/thorduri/go-libusb
[2] https://github.com/kylelemons/gousb
[3] https://github.com/google/gousb
The text was updated successfully, but these errors were encountered: