Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yubikey-manager requires python-fido2 < 0.90 but Fedora 34 uses python-fido2 0.90-2 #382

Closed
gbcox opened this issue Jan 29, 2021 · 19 comments

Comments

@gbcox
Copy link

gbcox commented Jan 29, 2021

Refer to: #378

Currently F34 is being built for testing and it includes python-fido2 0.90-2.
F34 is schedule to be released approximately, April 2021.

Will a compatible version be released in time? Thanks much!

@dainnilsson
Copy link
Member

Thanks for the heads up! We aim to have yubikey-manager 4.0 out by April (probably towards the end of March). Barring any big delays we should be able to meet this.

@gbcox
Copy link
Author

gbcox commented Jan 29, 2021

Thank you very much. In the meantime if you have a beta build available, please let me know and I'll put it in the F34 repository so people can use it to test.

@nbraud
Copy link
Contributor

nbraud commented Feb 1, 2021

OK; that would probably be too late for Debian bullseye (though maybe I can squeeze in a last update if I ask the release team nicely) so I'll roll back python-fido2 0.9.0 tomorrow or so

@dainnilsson
Copy link
Member

@nbraud is there a specific date when a ykman 4.0 release would have to be done by to make it into Bullseye?

@nbraud
Copy link
Contributor

nbraud commented Feb 1, 2021

The date for full freeze is yet to be announced, but hard freeze will be on March 12th.
PS: Forgot to mention, but since yubikey-manager and python-fido2 do not have autopkgtests, it would have to be before the hard freeze.

@dainnilsson
Copy link
Member

We're looking at moving the release date for this to target the end of Feb instead. Would that mean we still have a shot at making it into Bullseye?

@nbraud
Copy link
Contributor

nbraud commented Feb 3, 2021

Yeah, definitely. Thanks <3

@dainnilsson
Copy link
Member

I've now released an alpha: 4.0.0a1. It's published to PyPI and also tagged in this repo.
Note that we also just released python-fido2 0.9.1 to include some error code definitions that were missing in the 0.9.0 release.

There are substantial build-system changes to ykman 4.0.0, I hope these do not cause issues for packaging. If they do, let us know and we'll see what we can do about it!

@nbraud
Copy link
Contributor

nbraud commented Feb 3, 2021

I've now released an alpha: 4.0.0a1. It's published to PyPI and also tagged in this repo.

Thanks a lot, this does save me a lot of work :)
(I had started forward-porting the last release to fido2 0.9.x, which didn't seem to be all that easy...)

Note that we also just released python-fido2 0.9.1 to include some error code definitions that were missing in the 0.9.0 release.
There are substantial build-system changes to ykman 4.0.0, I hope these do not cause issues for packaging. If they do, let us know and we'll see what we can do about it!

OK; I'll have a stab at packaging that shortly, and I'll let you know how it goes.

@nbraud
Copy link
Contributor

nbraud commented Feb 3, 2021

Done. This wasn't entirely easy (Poetry isn't packaged in Debian yet, and I hit some dh-python bug when using a setup.py file generated by dephell) and I had to disable automated tests for the moment (test dependencies not packaged in Debian yet) but I'll try to improve the situation soonish.

@gbcox
Copy link
Author

gbcox commented Feb 3, 2021

Should I be building from 4.0.0a1 or next? I noticed some errors on 4.0.0a1...
Thanks!

@dainnilsson
Copy link
Member

What kind of errors? Development will continue on next where any issues we find i the alpha will be addressed. So far there's a commit or two, but nothing major, and 4.0.0a1 should work just fine, so I'd suggest targeting that for packaging for now.

@gbcox
Copy link
Author

gbcox commented Feb 3, 2021

Well, when I unzipped the archive, it didn't have a setup.py

@nbraud
Copy link
Contributor

nbraud commented Feb 3, 2021

Well, when I unzipped the archive, it didn't have a setup.py

Yes, ykman switched to using the Poetry build system.

@gbcox
Copy link
Author

gbcox commented Feb 3, 2021

Well, when I unzipped the archive, it didn't have a setup.py

Yes, ykman switched to using the Poetry build system.

ok, I have no idea what that is... need to research. Thanks!

@gbcox
Copy link
Author

gbcox commented Feb 4, 2021

... I had to disable automated tests for the moment (test dependencies not packaged in Debian yet) but I'll try to improve the situation soonish.

Yeah, I got multiple test failures, so I commented it out for the time being:

ImportError: Failed to import test module: tests.device
ImportError: Failed to import test module: tests.test_piv
ImportError: Failed to import test module: tests.test_scancodes
ImportError: Failed to import test module: tests.test_util
ImportError: Failed to import test module: ykman

I did notice when doing a test install that yubioath-manager stopped working. The yubikey wasn't recognized. Will yubioath need to be upgraded at the same time as manager?

@dainnilsson
Copy link
Member

Yes, yubioath will also need a new version to be compatible with ykman 4.0. Unfortunately that one is a bit further out. We package it together with its dependencies (installers for Windows and MacOS, and as a Snap package) so I hadn't considered the impact here. I take it there's no way of doing something similar for Fedora and Debian, or of having multiple versions of a package available?

@dainnilsson
Copy link
Member

Quick update on this: 4.0.0a3 has just been released. No major changes, but some fixes and tweaks based on our testing of the earlier build. It looks like we'll be targeting March 2nd for release of the final 4.0.0 version. Is that ok with you @nbraud for getting it into Bullseye?

@dainnilsson
Copy link
Member

ykman 4.0.0 has now been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants