Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ykman has a check which prevents use of python >= 23.4 - F40 will use 24.2 #570

Closed
gbcox opened this issue Sep 5, 2023 · 9 comments
Closed

Comments

@gbcox
Copy link

gbcox commented Sep 5, 2023

  • YubiKey Manager (ykman) version: 5.2.0
  • How was it installed?: Fedora rpm
  • Operating system and version: Fedora 40 (currently rawhide) - Scheduled production date approx. May, 2024
  • YubiKey model and version: N/A
  • Bug description summary:
    Installation message:

can't install python3-yubikey-manager:

  • nothing provides (python3.12dist(keyring) < 24~~ with python3.12dist(keyring) >= 23.4) needed by python3-yubikey-manager-5.2.0-1.20230821gitd1bf843.fc40.noarch

FYI... F40 will be using :
python-keyring-24.2.0-1.fc40
So python level check needs to be adjusted prior to May, 2024.
You probably are already aware, but thought I'd create a bug report, just in case.
Thanks much!

@musicinmybrain
Copy link

This seems to be fixed in a956fad.

@gbcox
Copy link
Author

gbcox commented Sep 20, 2023

@dainnilsson Can you please comment as to whether a956fad can be applied in isolation. I'd hate to push it only to find out it caused unintended consequences. Thanks!

@dainnilsson
Copy link
Member

As in applying only that commit onto the latest release? I believe that should work, yes. If there isn't a big rush for it you may want to wait for the next release which will include the commit which will likely be in 1-2 weeks.

@gbcox
Copy link
Author

gbcox commented Sep 21, 2023

@dainnilsson I noticed that for the keyring you specify ^24. So, if I'm interpreting this correctly you're saying that version 23.+ is no longer compatible and version 24 is required? If that is the case, then I'll need to freeze the versions on Fedora 38 and Fedora 39 where they are and only update Fedora 40 (currently in rawhide). Either that, or get keyring on F38 and F39 upgraded (keyring on F38 and F39 is currently at 23). Thanks!

@dainnilsson
Copy link
Member

Well, it should still be fully compatible and maybe a less strict bump to include both major versions would be more appropriate. There were no changes to our code base required to support the new version, but we will stop testing with 23.x so it's possible that over time we will drop compatibility. Would continuing to have "official" support for 23.x be helpful then in this case, to better support more Fedora versions?

@gbcox
Copy link
Author

gbcox commented Sep 21, 2023

@dainnilsson If both versions are still fully compatible it would definitely be helpful to have both versions allowed.

@dainnilsson
Copy link
Member

Then I will go ahead with that. As version 24 doesn't actually add anything new, nor remove anything we depend upon, we should be safe from accidentally depending on features only available in 24.+ and thereby breaking support for 23.

@gbcox
Copy link
Author

gbcox commented Sep 21, 2023

@dainnilsson Great. Thank you very much!

@dainnilsson
Copy link
Member

5.2.1 is now released with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants