NewCredentialView.qml imports QtQuick.Dialogs from deprecated Qt Quick Controls 1

[mkszuba]

• Yubico Authenticator version: at least 5.1.0 and newer, including current state of Git main branch
• Operating system and version: Linux with Qt-5.15
• YubiKey model and version: N/A
• Bug description summary:

Even though Yubico Authenticator build scripts explicitly look for Qt Quick Controls 2, the QML script NewCredentialView.qml attempts to import the module QtQuick.Dialogs - part of Qt Quick Controls 1. This prevents yubioath-desktop from being launched on systems which do not have both versions of QtQuick Controls installed.

Steps to reproduce

1. Build and install Yubico Authenticator
2. Uninstall Qt Quick Controls 1 if present
3. Attempt to launch yubioath-desktop

Expected result

The program starts.

Actual results

The program prints out

Got library name:  "/usr/lib64/qt5/qml/io/thp/pyotherside/libpyothersideplugin.so"
QQmlApplicationEngine failed to load component
qrc:/qml/main.qml:454:5: Type Navigator unavailable
qrc:/qml/Navigator.qml:350:9: Type NewCredentialView unavailable
qrc:/qml/NewCredentialView.qml:6:1: module "QtQuick.Dialogs" is not installed

and fails to launch.

Other info

It seems that merely removing the offending import from the NewCredentialView.qml is enough to address the issue - which is in line with the comment from https://doc.qt.io/qt-5/qtquickcontrols2-differences.html about the old and the new APIs being mostly compatible.

[dainnilsson]

Yubico Authenticator 6.0 has now been released and uses a new codebase. As such, this issue has been marked with the legacy label, and will be automatically closed in 7 days. If this issue is still relevant to Yubico Authenticator 6, please comment on the issue saying so, and it will be kept open (or be re-opened). Sorry for the inconvenience!