Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReplicaState::LogPrefix could be lockfree #580

Closed
spolitov opened this issue Nov 13, 2018 · 0 comments
Closed

ReplicaState::LogPrefix could be lockfree #580

spolitov opened this issue Nov 13, 2018 · 0 comments
Assignees
@spolitov
Labels
kind/enhancement This is an enhancement of an existing feature

Comments

@spolitov
Copy link
Contributor

We already have lockfree ReplicaState::GetRoleAndTerm, so LogPrefix could just use it and avoid tacking lock.
So we could avoid zoo of LogPrefix, LogPrefixUnlocked and LogPrefixThreadSafe for ReplicaState.
@spolitov spolitov self-assigned this Nov 13, 2018
yugabyte-ci pushed a commit that referenced this issue Nov 13, 2018
@spolitov
#580: Make ReplicaState::LogPrefix lockfree
6d51b83 
Summary:
We already have lockfree ReplicaState::GetRoleAndTerm, so LogPrefix could just use it and avoid tacking lock.
So we could avoid zoo of LogPrefix, LogPrefixUnlocked and LogPrefixThreadSafe for ReplicaState.

Test Plan: Jenkins

Reviewers: mikhail, robert, timur

Reviewed By: timur

Subscribers: ybase, bharat

Differential Revision: https://phabricator.dev.yugabyte.com/D5707
@kmuthukk kmuthukk added the kind/enhancement This is an enhancement of an existing feature label Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spolitov spolitov

Labels
kind/enhancement This is an enhancement of an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spolitov @kmuthukk