Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MasterFailoverTest.TestRenameTableSync is broken by "Don't replicate lease before replicating no op" (#660) #767

Closed
mbautin opened this issue Jan 17, 2019 · 0 comments
Closed

MasterFailoverTest.TestRenameTableSync is broken by "Don't replicate lease before replicating no op" (#660) #767

mbautin opened this issue Jan 17, 2019 · 0 comments
Assignees
@spolitov
Labels
kind/bug This issue is a bug

Comments

@mbautin
Copy link
Collaborator

mbautin commented Jan 17, 2019

./yb_build.sh release --cxx-test integration-tests_master_failover-itest --gtest_filter MasterFailoverTest.TestRenameTableSync -n 20 fails almost every time on the commit ad89fcb, but passes almost every time on the preceding commit.
@mbautin mbautin added the kind/bug This issue is a bug label Jan 17, 2019
yugabyte-ci pushed a commit that referenced this issue Jan 18, 2019
@spolitov
[#767]: Don't use custom leader_failure_max_missed_heartbeat_periods …
d950e6d 
…in MasterFailoverTest

Summary:
MasterFailoverTest changes leader_failure_max_missed_heartbeat_periods to speedup leader failure detection.
But it also causes very tight time bounds for new leader to load sys catalog.
That is causing to fall into state when master leader constantly reelected.

Removed setting custom value for this flag, so test could operation normally.

Also added log prefix to heartbeater logs and improved diagnostics in ExternalMiniCluster::WaitForTabletServerCount.

Test Plan: ybd --cxx-test integration-tests_master_failover-itest --gtest_filter MasterFailoverTest.TestRenameTableSync -n 20

Reviewers: timur, mikhail

Reviewed By: mikhail

Subscribers: ybase, bharat

Differential Revision: https://phabricator.dev.yugabyte.com/D6016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spolitov spolitov

Labels
kind/bug This issue is a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbautin @spolitov