Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YSQL] Secondary index read does not use a consistent read point. #990

Closed
robertpang opened this issue Mar 14, 2019 · 3 comments

Comments

@robertpang
Copy link
Contributor

commented Mar 14, 2019

In YBCIndexExecuteSelect(), the YBC select statement to fetch the row from the base table using the ybctid is not created with a read point:

HeapTuple
YBCIndexExecuteSelect(Relation relation, Datum ybctid)
{
    YBCPgStatement ybc_stmt;
    TupleDesc      tupdesc = RelationGetDescr(relation);

    HandleYBStatus(YBCPgNewSelect(ybc_pg_session,
                                  YBCGetDatabaseOid(relation),
                                  RelationGetRelid(relation),
                                  InvalidOid,
                                  &ybc_stmt,
                                  NULL /* read_time */));
...
}

Without the read point, the index select may not be reading the rows from the base table with a consistent read point.

@robertpang robertpang added the kind/bug label Mar 14, 2019

@robertpang robertpang added this to To do in SQL Support via automation Mar 14, 2019

@ndeodhar

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

@spolitov @nocaway The code fixes for #1894 and #1611 should take care of this, right? Can I close this?

@nocaway nocaway closed this Sep 4, 2019

SQL Support automation moved this from To do to Done Sep 4, 2019

@nocaway

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

@ndeodhar This has been fixed.

@kmuthukk

This comment has been minimized.

Copy link
Collaborator

commented Sep 4, 2019

Fixed as part of #1894 and #1611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.