Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YSQL] Secondary index read does not use a consistent read point. #990

Closed
robertpang opened this issue Mar 14, 2019 · 3 comments
Closed

[YSQL] Secondary index read does not use a consistent read point. #990

robertpang opened this issue Mar 14, 2019 · 3 comments
Labels
Projects

Comments

@robertpang
Copy link
Contributor

@robertpang robertpang commented Mar 14, 2019

In YBCIndexExecuteSelect(), the YBC select statement to fetch the row from the base table using the ybctid is not created with a read point:

HeapTuple
YBCIndexExecuteSelect(Relation relation, Datum ybctid)
{
    YBCPgStatement ybc_stmt;
    TupleDesc      tupdesc = RelationGetDescr(relation);

    HandleYBStatus(YBCPgNewSelect(ybc_pg_session,
                                  YBCGetDatabaseOid(relation),
                                  RelationGetRelid(relation),
                                  InvalidOid,
                                  &ybc_stmt,
                                  NULL /* read_time */));
...
}

Without the read point, the index select may not be reading the rows from the base table with a consistent read point.

@robertpang robertpang added this to To do in YSQL via automation Mar 14, 2019
@ndeodhar
Copy link
Contributor

@ndeodhar ndeodhar commented Aug 28, 2019

@spolitov @nocaway The code fixes for #1894 and #1611 should take care of this, right? Can I close this?

Loading

@nocaway nocaway closed this Sep 4, 2019
YSQL automation moved this from To do to Done Sep 4, 2019
@nocaway
Copy link
Contributor

@nocaway nocaway commented Sep 4, 2019

@ndeodhar This has been fixed.

Loading

@kmuthukk
Copy link
Collaborator

@kmuthukk kmuthukk commented Sep 4, 2019

Fixed as part of #1894 and #1611

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
YSQL
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants