Add memory limit to ram ratio #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmuthukk
reviewed
Aug 31, 2018
There was a problem hiding this comment.
Can you update the commit summary with something like:
In non-kubernetes deployment, yb-master process runs on the same node as the yb-tserver process, and only get a default 0.1 (10%) of node's RAM, and 0.85% of RAM is given to yb-tserver process. In kubernetes deployments since yb-master runs as its own pod, we should increase its default memory limit.
| @@ -49,6 +50,7 @@ Services: | |||
| rpc-port: "7100" | |||
| yql-port: "9042" | |||
| yedis-port: "6379" | |||
| memory_limit_to_ram_ratio: 1 | |||
There was a problem hiding this comment.
The default (for TServers) is already 0.85 and we don't want to change that. We want to leave some room for other processes.
There was a problem hiding this comment.
In other words, let us not override the TServer setting for memory limit in this yaml file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested by running helm install and validated
helm install yugabyte --name demo