Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifying the condition check in login() #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Modifying the condition check in login() #22

wants to merge 1 commit into from

Conversation

JosephT5566
Copy link
Contributor

@JosephT5566 JosephT5566 commented Jun 13, 2020 •
edited

  1. password is not necessary if login as guest

Fix what?

fix #19

Changes

  • login()中不需確認password

Note

看了ptt-client，password為空字串是OK的，不過最近ptt的guest太多(蟑螂盛行?)，無法用guest登入，就無法驗證XD

@JosephT5566
Modifying the condition check in login()
70cfe96 
1. password is unnecessary if login as guest
kevinptt0323
kevinptt0323 reviewed Jun 13, 2020
View reviewed changes
Copy link

@kevinptt0323 kevinptt0323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message: unnecessary => not necessary

@Yukaii Yukaii self-requested a review June 14, 2020 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinptt0323 kevinptt0323 kevinptt0323 left review comments

@Yukaii Yukaii Awaiting requested review from Yukaii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot login with "guest" account
2 participants
@JosephT5566 @kevinptt0323