New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crop improvements and toolbar overlapped fix #666
Crop improvements and toolbar overlapped fix #666
Conversation
Has this been merged? When you crop do you now get an outline of the crop area (again very hard to use with standard white background) |
@justdan0227 In the example below the |
Thanks until this is merged I can't find cropOverlayColor to try out your suggestion above? |
Try to checkout my fork: https://github.com/tsahi-deri/YPImagePicker |
Bingo! Thanks! |
Take a look with this crop functional already merged 6c5460a |
@NikKovIos My implementation was indeed based on that pull request but I also added a couple necessary fixes on top of it. Please take a look in PR description. |
@tsahi-deri Sorry, I didn't find your PR first. Could you please pull from YPImagePicker master and test your implementation. If it is ok, I will merge it too. |
434fcf2
to
21c694e
Compare
@NikKovIos Done, please check my PR. Thanks |
@NikKovIos Will you create a new release soon with all latest changes ? |
@tsahi-deri think so. Now @s2mr gonna check spm and cocapods dependency and then we will ready to release. |
@s2mr Hey, any update about the next release ? |
Why is it that cropOverlayColor is not found in master? Has this not been merged? |
@justdan0227 The branch is fully merged into master but a new version is not released yet. @s2mr any update about the next release ? |
Sorry, I don't know this topic. |
@s2mr Please see NikKovIos comment above regarding the a new release with all latest changes. |
Check 5.0.0 release please. |
Note:
This is my first experience using Stevia, so I believe there are more convenient ways to layout
YPCropView
subviews rather than my implementation.