Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify service requirements in manifest.json #1693

Closed
tituspijean opened this issue Dec 12, 2020 · 1 comment
Closed

Clarify service requirements in manifest.json #1693

tituspijean opened this issue Dec 12, 2020 · 1 comment

Comments

@tituspijean
Copy link

tituspijean commented Dec 12, 2020

Right now, the services requirements checks are a bit convoluted and boil down to checking that the following services are OK:

  • nginx is always added whatever the provided list
  • php7.3-fpm, replacing any other mention of php in the manifest
  • mysql
  • postfix
  • fail2ban is always added whatever the provided list

Other services are ignored, in opposition to the documentation:

services: services needed by the application among nginx, php5-fpm, mysql, uwsgi, metronome, postfix, dovecot

I suggest we either:

  • simplify the checks, acknowledge the limits of the services list in the documentation, and add linter warnings about custom services
  • expand the checks, and specify in the documentation that these checks only test for the services being OK and will not try to install them.
@alexAubin
Copy link
Member

Eh I was about to say "this is sort of fixed by the manifestv2" but in fact I might have dropped entirely the key and now no checks happens for v2 app ? Need to check the code ...

@alexAubin alexAubin closed this as not planned Won't fix, can't repro, duplicate, stale Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants