Confirm box should be internationalized - Cancel and OK buttons #849
Comments
File AttachmentAuthor: jibec File: YNH-bouton Cancel 2017-03-20 06-52-47.png (7.32 KB) |
Properties ChangeAuthor: moul |
Original Redmine CommentAuthor: Bram It's actually here https://github.com/YunoHost/yunohost-admin/blob/4f28ba44268de77527c7ae280b876ade4ca529b9/src/index.html#L79-L80 I don't know how we are supposed to make things translatable in the webadmin html. |
Original Redmine CommentAuthor: alexAubin Isn't this supposed to be a view/mustache thing like the others ? |
Original Redmine CommentAuthor: Bram The mustache stuff is only used for the dynamic content of the admin, the "body", the modal is stored as a global hidden html, that's probably a limitation of this current design. I guess it could be extracted as a mustache thinghy, opi should be able to tell us more about that. |
Original Redmine CommentAuthor: alexAubin Status Changed: Resolved We just tested it and couldn't reproduce : the string is translated (when loading the admin) using the key in data-y18n field. The only minor bug is that 'ok' is not a key, so the key is used and you get 'ok' (lowercase). This PR fixes it : YunoHost/yunohost-admin#171 |
Original Redmine Issue: 849
Author Name: jibec
In web admin, in screen upgrade/packages, the confirm box has "OK" or "Cancel" in French. It should be "Confirmer" ou "Annuler".
Please see screenshot.
I assume it should bring back the "cancel" from this string: https://github.com/YunoHost/yunohost-admin/blob/unstable/src/locales/fr.json#L55
but I can't find an "OK" string.
The box looks like to be build from this class:
https://github.com/YunoHost/yunohost-admin/blob/83127a5692fa6a8c25cb4599b613d6c6f05b574f/src/js/yunohost/helpers.js#L251
thanks for your help,
The text was updated successfully, but these errors were encountered: