Skip to content
This repository has been archived by the owner on Jan 15, 2022. It is now read-only.

Throw when anything is logged to stderr #2

Closed
Yurickh opened this issue Nov 10, 2019 · 2 comments
Closed

Throw when anything is logged to stderr #2

Yurickh opened this issue Nov 10, 2019 · 2 comments

Comments

@Yurickh
Copy link
Owner

Yurickh commented Nov 10, 2019

The problem

Right now users are unable to identify when their cli is breaking other than passing debug: true.

Suggested solution

Either throw an error with the chunk that was fed into stderr, or stop pipe-ing stderr and pass it into process.stderr.
You might get into some kind of timing issues, since clifford doesn't run the command on itself.

Rationale

By throwing we notify the consumer that something is wrong, rather than silencing the error.

@Yurickh
Copy link
Owner Author

Yurickh commented Jan 28, 2020

Alternatively we can provide a method to access their logs, akin to how we provide readLine and read.

@Yurickh
Copy link
Owner Author

Yurickh commented Oct 19, 2020

Will be solved by unifying stderr and stdout under readLine, read and similar method in #16

@Yurickh Yurickh closed this as completed Oct 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant