Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI build of Example project #20

Merged
merged 2 commits into from
May 14, 2022

Conversation

maiyama18
Copy link
Contributor

@maiyama18 maiyama18 commented May 13, 2022

close #17

As mentioned in #17, it's nice to make sure that public api of this package is not broken by building Example project for every PR. I added workflow to build both SwiftUI / UIKit versions of example apps.

It might be better if comprehensive tests for the package is added and executed on CI, but for now I think simply building Example project as CI is good idea.

I confirmed that this workflows works in my forked repository.
https://github.com/maiyama18/UserDefaultsBrowser/actions/runs/2319719282

@maiyama18 maiyama18 marked this pull request as ready for review May 13, 2022 13:37
@YusukeHosonuma
Copy link
Owner

@maiyama18
Awesome! Good job 👍
Thanks again for the contribution.

@YusukeHosonuma YusukeHosonuma merged commit 7e6e18c into YusukeHosonuma:main May 14, 2022
@maiyama18 maiyama18 deleted the ci-build branch May 14, 2022 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Actions でビルド
2 participants