Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies #2

Closed
wants to merge 1 commit into from
Closed

Fix dependencies #2

wants to merge 1 commit into from

Conversation

ryceg
Copy link

@ryceg ryceg commented Oct 3, 2022

I noticed that @swc/core and webpack were not listed as dependencies in the package.json, resulting in a poor DX- they might be globals on your machine. I've added them.

@Yuu6883
Copy link
Owner

Yuu6883 commented Oct 3, 2022

But it’s able to run in my GitHub action? It should work without global installs.

@ryceg
Copy link
Author

ryceg commented Oct 3, 2022

For fresh local installs, you need to list all dependencies. This is what happens at the moment when you npm i and then npm run start:

image

@Yuu6883
Copy link
Owner

Yuu6883 commented Oct 4, 2022

I don't have webpack installed globally yet it works on my Windows and the Ubuntu build server, it's either something wrong w MacOS or your npm. I will add webpack anyways

@Yuu6883 Yuu6883 closed this Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants