Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser & multi cmd #10

Open
aromanro opened this issue Feb 3, 2017 · 2 comments
Open

parser & multi cmd #10

aromanro opened this issue Feb 3, 2017 · 2 comments
Labels

Comments

@aromanro
Copy link

aromanro commented Feb 3, 2017

The parser used in the reference client and listener does not parse correctly multi commands. The reason is that it should subtract from command length the bytes for command class and command. The information is in the xml file as sizechange="-2" attribute, which is ignored by the parser.

@miline
Copy link
Member

miline commented Feb 28, 2017

Can you give a sample bytestream?

@aromanro
Copy link
Author

aromanro commented Mar 1, 2017

Hopefully this helps:

./reference_listener -l 192.168.123.236
PSK not configured - using default
Listening on 192.168.123.236 port 41230
8F01030380033306310501420A640284
07

cmd_class:  COMMAND_CLASS_MULTI_CMD  v1
cmd:  MULTI_CMD_ENCAP 
    Number of Commands >
 	03
    Command Length >
 	003
    Command Class >
 	80
    Command >
 	03
    Data >

    Command Length >
 	051
    Command Class >
 	06
    Command >
 	31
    Data >

    Command Length >
 	005
    Command Class >
 	01
    Command >
 	42
    Data >

: More data in bytestream than needed?

bytestream:  8f 01 03 03 80 03 33 06 31 05 01 42 0a 64 02 84 07

It comes from a thermostat.

@anta anta added the bug label Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants