Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering for one "Most probable ML class" not possible with one box filter #123

Closed
B-Hartmann opened this issue May 17, 2022 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@B-Hartmann
Copy link
Contributor

ShapeOut 2.11.0

When using a box filter to only get events with the same "most probable ml class", let's say, ml_class = 4, I run into the following problem:
The box filter for that feature only allows integer values, and when I filter with min=4 and max=4, the filter does not work at all, but if I filter with min=3 and max=4, both classes, 3 and 4, are selected, although I only want ml_class = 4.

The current workaround is to use two filters, one with min=3 and max=4 and the other one with min=4 and max=5.
I think it would be nice if the box filter would work by setting min and max value of the filter to the same value (4 in my example).

@paulmueller paulmueller added the bug Something isn't working label May 17, 2022
@paulmueller
Copy link
Member

OK, on second thought this might be more complicated. If you define a box filter for integer features, you usually always have the boundaries included. This behavior would change if we fixed this issue (which is bad).

One option would be to make the sliders work with floating point values (e.g. including 0.5 steps). Then the user can fine-grain.

@B-Hartmann
Copy link
Contributor Author

I am not sure I can follow your thoughts. If the boundaries were included, that would be exactly what I wanted. Why would the behavior change if the bug was fixed?

@paulmueller
Copy link
Member

If you set min=3 and max=4 and you get both classes, then the boundaries (min and max) are included. My initial thought was that one of the boundaries should not be included (so you only get one class), but that might break other pipelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants