Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

110 users can get more information on terms in the wiki #170

Merged

Conversation

pascalalferink
Copy link
Collaborator

No description provided.

Copy link
Contributor

@antw antw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me, but I haven't been able to test it because I can't figure out how to create text that links to a StaticTermPage. 😕

I have a Static page and a StaticTermPage, and within the Static have tried writing text (that gets rendered by RawHtml) with the same name as the StaticTermPage. I tried both the value for the "Introduction" and the page title, and also tried linking to it directly but don't get any underlined text or a modal. Am I doing something wrong?

frontend/components/RawHtml/RawHtml.tsx Outdated Show resolved Hide resolved
@mattijsstam
Copy link
Collaborator

The code looks good to me, but I haven't been able to test it because I can't figure out how to create text that links to a StaticTermPage. 😕

I have a Static page and a StaticTermPage, and within the Static have tried writing text (that gets rendered by RawHtml) with the same name as the StaticTermPage. I tried both the value for the "Introduction" and the page title, and also tried linking to it directly but don't get any underlined text or a modal. Am I doing something wrong?

@antw you have to highlight text in the rich text editor and then you can replace the highlighted text with a term. I agree that the default interface is not intuitive

Copy link
Contributor

@antw antw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to test the modal (thanks @mattijsstam!) and found two small issues. Other than those, this feature worked perfectly.

frontend/components/RawHtml/RawHtml.tsx Show resolved Hide resolved
frontend/components/RawHtml/RawHtml.tsx Outdated Show resolved Hide resolved
pascalalferink and others added 2 commits November 17, 2022 11:18
Co-authored-by: Anthony Williams <hi@antw.dev>
Co-authored-by: Anthony Williams <hi@antw.dev>
antw
antw previously approved these changes Nov 17, 2022
antw
antw previously approved these changes Nov 17, 2022
@mattijsstam mattijsstam marked this pull request as draft November 17, 2022 15:18
@mattijsstam mattijsstam marked this pull request as ready for review November 18, 2022 10:55
Copy link
Collaborator

@broekhuisg broekhuisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getest en het werkt. Echt super tof gedaan!

@mattijsstam mattijsstam merged commit 0f121be into main Nov 18, 2022
@mattijsstam mattijsstam deleted the 110-users-can-get-more-information-on-terms-in-the-wiki branch November 18, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users can get more information on terms in the wiki
4 participants