New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
110 users can get more information on terms in the wiki #170
110 users can get more information on terms in the wiki #170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me, but I haven't been able to test it because I can't figure out how to create text that links to a StaticTermPage. 😕
I have a Static page and a StaticTermPage, and within the Static have tried writing text (that gets rendered by RawHtml) with the same name as the StaticTermPage. I tried both the value for the "Introduction" and the page title, and also tried linking to it directly but don't get any underlined text or a modal. Am I doing something wrong?
@antw you have to highlight text in the rich text editor and then you can replace the highlighted text with a term. I agree that the default interface is not intuitive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to test the modal (thanks @mattijsstam!) and found two small issues. Other than those, this feature worked perfectly.
Co-authored-by: Anthony Williams <hi@antw.dev>
Co-authored-by: Anthony Williams <hi@antw.dev>
…e-information-on-terms-in-the-wiki
… add wiki page title to modal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getest en het werkt. Echt super tof gedaan!
No description provided.