Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Compilation Issues When Using as Standalone Library #16

Open
nocholasrift opened this issue Nov 2, 2022 · 0 comments
Open

Minor Compilation Issues When Using as Standalone Library #16

nocholasrift opened this issue Nov 2, 2022 · 0 comments

Comments

@nocholasrift
Copy link

Hi there! I was compiling some code in C++17 that uses the GCOPTER headers for a current research project, and noticed 2 compilation errors that I figured I'd bring up:

  1. gcopter.hpp uses methods in the geo_utils namespace, but doesn't directly or indirectly #include "geo_utils.hpp". Adding the include seemed to fix the problem.
  2. The filterLess struct operator() function in geo_utils.hpp isn't const. Changing the function header to the following allowed me to compile successfully:
    inline bool operator()(const Eigen::Vector3d &l, const Eigen::Vector3d &r) const;

Thanks for sharing this framework, it's very nicely done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant