Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Minor Fix against zoralabFORM UI Toggle #403

Closed
hollowaykeanho opened this issue Jul 14, 2023 · 2 comments
Closed

Minor Fix against zoralabFORM UI Toggle #403

hollowaykeanho opened this issue Jul 14, 2023 · 2 comments
Assignees
@hollowaykeanho
Labels
Artwork Case is about an art direction. Bug Case is about a technical glitch. HestiaHUGO All Hestia Hugo related matter. Released Implementation got released and shipped.

Comments

@hollowaykeanho
Copy link
Member

hollowaykeanho commented Jul 14, 2023 •
edited

Description

Please provide a short description of what you have encountered below.

The toggle button can go out of shape again when used in zoralabCARD. Requires fixing.

Expected Behavior

Please specify the expected behavior of your usage below.

Apply the following CSS changes:

  1. Remove top:50%, transform: translateY(-50%) for both toggle background and toggle button.
  2. Apply margin: calc((var(--form-switchbox-toggle-width)/2)*.1) 0 to the toggle button since it has missing dimensions in its calculation.

Current Behavior

Please specify the current behavior of software below.

Out of shape.

Steps to Reproduce (COMPULSORY)

Please specify all the steps required to re-produce the problem.

Attachments

Please drag and drop the necessary data files (e.g. screenshot, logs, etc)
below.
@hollowaykeanho hollowaykeanho added Bug Case is about a technical glitch. Discussion Matter is still in discussion. No commitment yet. HestiaHUGO All Hestia Hugo related matter. Artwork Case is about an art direction. and removed Discussion Matter is still in discussion. No commitment yet. labels Jul 14, 2023
@hollowaykeanho hollowaykeanho self-assigned this Jul 14, 2023
@hollowaykeanho hollowaykeanho added the Doing Someone is working on the case. label Jul 14, 2023
@hollowaykeanho
Copy link
Member Author

fixed in 1977371

@hollowaykeanho hollowaykeanho added Done and Pending Release Completed and staging for next release. and removed Doing Someone is working on the case. labels Jul 14, 2023
@hollowaykeanho
Copy link
Member Author

Released in version v1.2.2.

@ZORALab ZORALab locked as resolved and limited conversation to collaborators Jul 16, 2023
@hollowaykeanho hollowaykeanho added Released Implementation got released and shipped. and removed Done and Pending Release Completed and staging for next release. labels Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hollowaykeanho hollowaykeanho

Labels
Artwork Case is about an art direction. Bug Case is about a technical glitch. HestiaHUGO All Hestia Hugo related matter. Released Implementation got released and shipped.
Projects
No open projects
ZORALab's Hestia Project
Status: [ DELIVERED ] v1.2.2 and before
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hollowaykeanho