Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add resizeMode prop #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

drewdulz
Copy link

No description provided.

@geminiyellow
Copy link

i think you can set it type to enum,

here: https://facebook.github.io/react-native/docs/image#resizemode

@drewdulz
Copy link
Author

I have no experience with typescript, so i'm not certain this is correct, but I think i've changed the type to enum.

@drewdulz
Copy link
Author

Can we get this PR reviewed?

@geminiyellow
Copy link

geminiyellow commented Jan 31, 2019

hi @wmcbain please merge this PR and Close: #5

@drewdulz
Copy link
Author

@geminiyellow shouldn't the issue be closed after the code is merged and released?

@geminiyellow
Copy link

@drewdulz yep, you can use github Close tag in comment, when your PR is merged, it will auto close issue.

@drewdulz
Copy link
Author

drewdulz commented Jan 31, 2019

oh haha I thought you were asking wmcbain to close the issue manually. That's a pretty cool github feature!

@drewdulz
Copy link
Author

@wmcbain? Can this be merged?

@wmcbain
Copy link
Contributor

wmcbain commented May 24, 2019

@geminiyellow @drewdulz I unfortunately no longer have write access.

Inquiring about getting ownership transferred. Otherwise will fork.

@geminiyellow
Copy link

woo, sounds no good. thank you @wmcbain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants