Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Tox environments in CONTRIBUTING.md? #114

Closed
kianmeng opened this issue Jan 30, 2023 · 1 comment · Fixed by #115
Closed

Missing Tox environments in CONTRIBUTING.md? #114

kianmeng opened this issue Jan 30, 2023 · 1 comment · Fixed by #115

Comments

@kianmeng
Copy link
Contributor

$ tox -av
using tox.ini: /tmp/flake8-trio/tox.ini (pid 252136)
using tox-3.25.0 from /home/foobar/.local/lib/python3.10/site-packages/tox/__init__.py (pid 252136)
default environments:
py39-flake8_5  -> Runs pytest, optionally with posargs
py39-flake8_6  -> Runs pytest, optionally with posargs
py310-flake8_5 -> Runs pytest, optionally with posargs
py310-flake8_6 -> Runs pytest, optionally with posargs
py311-flake8_5 -> Runs pytest, optionally with posargs
py311-flake8_6 -> Runs pytest, optionally with posargs

In https://github.com/Zac-HD/flake8-trio/blob/main/CONTRIBUTING.md

tox -e check
tox -e py311
@jakkdl
Copy link
Member

jakkdl commented Jan 30, 2023

Ah I'm sorry, tox -e check is outdated - it should be pre-commit run --all-files.
Will fix~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants