Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix trio100 removing trailing comment with same-line with #186

Merged

Conversation

jakkdl
Copy link
Member

@jakkdl jakkdl commented Apr 30, 2023

added basic test case showing the problem, this was the cause of my confusion in #182 with comments disappearing.

todo: write a fix

@jakkdl jakkdl force-pushed the autofix_100_same_line_eating_comments branch from 847874a to ec5f15a Compare May 1, 2023 10:59
@jakkdl jakkdl marked this pull request as ready for review May 1, 2023 10:59
@jakkdl
Copy link
Member Author

jakkdl commented May 1, 2023

thought it'd be trickier than this, but past me had written good code and libcst is nice ☺️

Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's even nicer than I expected from your comment 🤩

@Zac-HD Zac-HD merged commit f970400 into python-trio:main May 1, 2023
6 checks passed
@jakkdl jakkdl deleted the autofix_100_same_line_eating_comments branch May 1, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants