Make black optional #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am trying to reduce the usage of linting programs like black or isort in nixpkgs to make programs less likely to break when they are updated and they trigger fewer rebuilds.
|
Hi Sandro - I'm happy to reduce the installation dependencies, but Black is already only a test-time dependency and this is an important semantic test to run. |
|
Nixpkgs runs tests to make sure the packages we ship are compatible. Black is a problematic dependency because if formatting changes in an update (which already happened a couple of times) tests fail for ignorable reasons. We then need to disable those tests for the builds to succeed. The best for us is when static analysis and linting tools are not run in test suites to make sure only actually breakages make the tests fail. |
|
Read the tests, they don't fail on formatting changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to reduce the usage of linting programs like black or isort in nixpkgs to make programs less likely to break when they are updated and they trigger fewer rebuilds.