Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-service preferences #61

Open
ZacSweers opened this issue Oct 18, 2017 · 1 comment
Open

Per-service preferences #61

ZacSweers opened this issue Oct 18, 2017 · 1 comment

Comments

@ZacSweers
Copy link
Owner

I think this could be done in a tasteful manner that gets some customization without getting too complicated.

Couple ideas:

  • ServiceMeta could include an R.xml reference to a preferences file that could be displayed for that service. Gives them full power with basic preferences while making the scope pretty small and keeps catchup-main from needing to know anything specific about it.
  • Alternatively - could start their own (possibly unique) preferences activity/controller for full control? This would be extreme, but then services could even manage their own auth or more fine grained controls (think "list of subreddits" for reddit)
    • I'm still pretty against having auth support right now, but if it were implemented, it would probably be via something like this.

Other notes

  • servicemeta would need to be extracted to something that's at app-scope to be shared across activities, unless the About and Settings activities were pushed down into their own Controllers. I think app scope is fine though as they're pretty lightweight.
@ZacSweers
Copy link
Owner Author

Some ideas of service prefs:

Reddit:

  • Custom subreddits
  • Auth?!?

GitHub:

  • Specify your own query
  • Language filter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant