This repository has been archived by the owner on Mar 30, 2020. It is now read-only.
Defaults support #17
Merged
Defaults support #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fair amount of cleanup/refactoring done in Barbershop as well. This allows for the use of a `defaultValue` option in the StlyedAttr annotation, where you can specify a resource to fall back to.
|
Talked with some people, not really going to consider adding defaults support in |
|
Usually defaults are set in a style which is either specified as an default theme attr or default style to the typed array creation so I agree 👍 |
|
Exactly. Yay finally supporting defaults! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #16
This allows for the use of a new
defaultValueoption inStyledAttrannotations, where you can set a resource ID to use as a default.The generated code will still check
Requiredif the annotation is there. It will not resolve the default value unless there is no resource at that index (that is, it won't unnecessarily resolve it just to pass it into the second param of many of the typedarray getters).AndroidAttrdoesn't support defaults, because it doesn't really make sense to. It would really have to force the user to only use it on setters to be practical.