Skip to content
This repository has been archived by the owner on Mar 30, 2020. It is now read-only.

Simplify acp #25

Merged
merged 1 commit into from
May 22, 2016
Merged

Simplify acp #25

merged 1 commit into from
May 22, 2016

Conversation

kageiit
Copy link

@kageiit kageiit commented May 22, 2016

  • Remove unnecessary configuration and convention
  • Move most configuration to extension
  • Provide support to get android dependencies from any 'provided' like plugin
  • When depending on project dependencies in apt configuration, also need to add a dependency on the acp configuration. This is not required once the compiler jar is packaged

@ZacSweers
Copy link
Owner

So to confirm, only the annotation processing library itself needs to specify the config but consumers of that processor later don't?

@kageiit
Copy link
Author

kageiit commented May 22, 2016

So to confirm, only the annotation processing library itself needs to specify the config but consumers of that processor later don't?

Correct. Consumers do not even know that acp was used. This approach is api-invisible

@ZacSweers
Copy link
Owner

Ignoring CI for now because I'll fix that later

@ZacSweers ZacSweers merged commit 806bb75 into ZacSweers:acp May 22, 2016
@ZacSweers
Copy link
Owner

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants